Wednesday, 31 March 2010
Bug: Eliminate unnecessary sorting in enumerating accounts, sessions, and persistent logins
When enumerating public accounts for the browse public accounts page, or
all user accounts, open sessions, or persistent login tokens for the
administrator, we unnecessarily sorted the names of the files in the
respective directories before retrieving them into the hash used to
build the displayed table. Since the table generation code sorts the
hash keys, there is no need to sort the file names, which can be very
time consuming when these directories get large. If these directories
get very much larger, it may make sense to read them serially and
perform the {\tt grep()} on them within the loop rather than bringing
the directory into memory and using the {\tt grep()} function as presently
done.
Subscribe to:
Post Comments (Atom)
No comments:
Post a Comment